Skip to content

fix(evals): strip evals sigil before root fallback to run handler#2109

Merged
miguelg719 merged 1 commit into
browserbase:miguelgonzalez/stg-1880-evals-nail-tui-onboarding-experience-and-command-discoveryfrom
chromiebot:chromie/chore-couple-of-review-comments-on-p
May 11, 2026
Merged

fix(evals): strip evals sigil before root fallback to run handler#2109
miguelg719 merged 1 commit into
browserbase:miguelgonzalez/stg-1880-evals-nail-tui-onboarding-experience-and-command-discoveryfrom
chromiebot:chromie/chore-couple-of-review-comments-on-p

Conversation

@chromiebot
Copy link
Copy Markdown
Contributor

@chromiebot chromiebot commented May 11, 2026

When user input like evals act hits the unknown-token root fallback, the full tokens array (including the leading "evals") was forwarded to the run handler. parseRunArgs would then misinterpret "evals" as a target or flag.

Strip the leading "evals" token before delegating to the run handler so only the intended arguments are forwarded.

Addresses cubic-dev-ai review comment on PR #2100.

why

what changed

test plan


Summary by cubic

Fixes a parsing bug where inputs like evals act were sent to the run handler with the evals sigil included, causing parseRunArgs to misinterpret it. We now strip the leading evals token before delegating so only the intended args are passed.

  • Bug Fixes
    • Strip leading evals token in the root fallback before invoking the run handler.
    • Added a test to ensure ["evals", "act"] dispatch forwards ["act"].

Written for commit 9a6fab5. Summary will update on new commits.

When user input like `evals act` hits the unknown-token root fallback,
the full tokens array (including the leading "evals") was forwarded to
the run handler. parseRunArgs would then misinterpret "evals" as a
target or flag.

Strip the leading "evals" token before delegating to the run handler
so only the intended arguments are forwarded.

Addresses cubic-dev-ai review comment on PR browserbase#2100.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

⚠️ No Changeset found

Latest commit: 9a6fab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

@github-actions github-actions Bot added external-contributor Tracks PRs mirrored from external contributor forks. external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. labels May 11, 2026
@miguelg719 miguelg719 merged commit 2f5c929 into browserbase:miguelgonzalez/stg-1880-evals-nail-tui-onboarding-experience-and-command-discovery May 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. external-contributor Tracks PRs mirrored from external contributor forks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants