fix(yarn): resolve stale git commit hashes blocking fresh installs#433
Open
r-sayar wants to merge 1 commit into
Open
fix(yarn): resolve stale git commit hashes blocking fresh installs#433r-sayar wants to merge 1 commit into
r-sayar wants to merge 1 commit into
Conversation
libsignal and @electron/node-gyp were pinned to commit hashes that no longer exist on any branch, causing `yarn install` to fail for anyone without those exact SHAs in their local git cache. Replaced the resolved SHA pins with branch-head references so the lockfile resolves cleanly on a fresh clone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yarn installfails on a fresh clone with:Two entries in
app/yarn.lockwere resolved to specific commit SHAs that no longer exist on any branch of their respective repos (whiskeysockets/libsignal-nodeandelectron/node-gyp). This breaksyarn installfor anyone on a fresh clone without those exact SHAs already in their local git object store.Fix
Replace the stale SHA pins with branch-head references (
master/main) so Yarn can resolve them cleanly.Test plan
yarn installcompletes without error on a fresh clonetask upstarts the app normally🤖 Generated with Claude Code
Summary by cubic
Fixes yarn install failures on fresh clones by updating git dependency resolutions in
app/yarn.lock. Replaces stale commit SHAs forlibsignaland@electron/node-gypwith branch heads so installs resolve cleanly.@electron/node-gyp: switch tohttpsand#maininstead of a deleted SHA.libsignal: switch tohttpsand#masterinstead of a deleted SHA.Written for commit 83f2cfc. Summary will update on new commits. Review in cubic