[fix] fix unhandled callback error for submittables #3589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Submittable is passed to client.query()
with query_timeout configured but WITHOUT a callback, the client would crash. This is especially problematic because it forces accumulation on Queries which the caller might not want if using on('row') event handlers. See: https://github.com/brianc/node-postgres/blob/master/packages/pg/lib/query.js#L79