Skip to content

Comments

Remove non-functioning brev secret command#290

Merged
theFong merged 1 commit intomainfrom
remove-secret-command
Feb 25, 2026
Merged

Remove non-functioning brev secret command#290
theFong merged 1 commit intomainfrom
remove-secret-command

Conversation

@theFong
Copy link
Member

@theFong theFong commented Feb 24, 2026

Summary

  • Remove the brev secret CLI command which was a non-functioning feature
  • Delete the secret store types and API method (pkg/store/secret.go)
  • Remove command registration from the CLI root

Test plan

  • Project compiles cleanly after removal
  • Verify brev secret is no longer available in CLI help output

Remove the secret command, its store types, and registration from the CLI.
@theFong theFong requested a review from a team as a code owner February 24, 2026 19:53
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.79%. Comparing base (272bf99) to head (fbd7962).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   13.10%   12.79%   -0.31%     
==========================================
  Files         112      113       +1     
  Lines       14480    14829     +349     
==========================================
  Hits         1898     1898              
- Misses      12349    12698     +349     
  Partials      233      233              
Flag Coverage Δ
Linux 12.79% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theFong theFong merged commit 7d53e72 into main Feb 25, 2026
10 of 11 checks passed
@theFong theFong deleted the remove-secret-command branch February 25, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants