feat(ui): replace spinner with skeleton loading screen on dashboard#5
Merged
feat(ui): replace spinner with skeleton loading screen on dashboard#5
Conversation
The dashboard previously showed a bare spinner + "Loading results..." text while waiting for the /api/results fetch. This gave no visual hint of page structure, causing layout shift when content arrived. Replaced with a full DashboardSkeleton component that mirrors the real layout: - Four stat cards (icon, value, sub-label placeholders) - Two chart panels with proportional bar columns - Recent Results table with six skeleton rows Uses the existing .skeleton shimmer CSS class (globals.css) — no new dependencies. The skeleton renders immediately on mount so the page always has visible content during the loading state. Also wires aria-busy='true' and aria-label on the skeleton root so screen readers know data is loading. Files: web/src/components/DashboardSkeleton.tsx (new), web/src/app/dashboard/page.tsx
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard showed a bare spinner while waiting for API results. This caused an abrupt layout shift and gave users no sense of the page structure.
Changes
web/src/components/DashboardSkeleton.tsx— full-layout skeleton with:web/src/app/dashboard/page.tsx— swap spinnerdivfor<DashboardSkeleton />Implementation notes
.skeletonshimmer CSS class fromglobals.css— zero new dependenciesaria-busy="true"+aria-labelon the skeleton root for screen reader supportnpm run buildpasses with no errors or warnings