Skip to content

fix(runtime): support cloning DataView objects#5235

Open
yush-1018 wants to merge 13 commits intoboa-dev:mainfrom
yush-1018:fix-dataview-clone
Open

fix(runtime): support cloning DataView objects#5235
yush-1018 wants to merge 13 commits intoboa-dev:mainfrom
yush-1018:fix-dataview-clone

Conversation

@yush-1018
Copy link
Contributor

Fixes #5167

This PR adds support for structuredClone() to clone DataView objects. Let me know if anything needs changes!

@yush-1018 yush-1018 requested a review from a team as a code owner March 23, 2026 09:31
@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics C-Runtime Issues and PRs related to Boa's runtime features and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 23, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 23, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,545 50,545 0
Ignored 1,426 1,426 0
Failed 992 992 0
Panics 2 2 0
Conformance 95.43% 95.43% 0.00%

Tested main commit: 66a1cd268ce6006918032b5d0f98d3a63c81b188
Tested PR commit: 6535f5c2ecca3358e2e1c7347fe69348e33f4d03
Compare commits: 66a1cd2...6535f5c

/// - [TC39 proposal][spec]
///
/// [spec]: https://tc39.es/proposal-joint-iteration/#sec-iterator.zip
fn zip(_: &JsValue, args: &[JsValue], context: &mut Context) -> JsResult<JsValue> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you pushed unrelated commits from another PR 😅

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 79.32011% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.92%. Comparing base (6ddc2b4) to head (6535f5c).
⚠️ Report is 916 commits behind head on main.

Files with missing lines Patch % Lines
...gine/src/builtins/iterable/iterator_constructor.rs 73.61% 43 Missing ⚠️
core/engine/src/builtins/iterable/zip_iterator.rs 89.59% 18 Missing ⚠️
core/runtime/src/store/from.rs 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5235       +/-   ##
===========================================
+ Coverage   47.24%   59.92%   +12.67%     
===========================================
  Files         476      583      +107     
  Lines       46892    63809    +16917     
===========================================
+ Hits        22154    38236    +16082     
- Misses      24738    25573      +835     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structuredClone() / postMessage() reject DataView values

2 participants