Open
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Reviewer's GuideAdds Stylelint-based CSS linting to the frontend build tooling and updates existing Vue/CSS styles to conform to the new lint rules, including normalizing zero units, cleaning up redundant/empty style blocks, and adjusting a few specific properties to match lint expectations. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
EndpointCard.vue,.endpoint-buttonskeepsgap: 8pxbut no longer setsdisplay: flex, which likely breaks the intended layout and makes thegapineffective; consider restoring the flex (or grid) display. - The
stylelint 'src/**/*.{vue,css,scss}'glob in the npm scripts may not work as expected on Windows shells due to single-quote handling and glob expansion; consider using double quotes or a cross-platform runner (e.g.cross-env-shellor a JS-based glob) if Windows support is needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `EndpointCard.vue`, `.endpoint-buttons` keeps `gap: 8px` but no longer sets `display: flex`, which likely breaks the intended layout and makes the `gap` ineffective; consider restoring the flex (or grid) display.
- The `stylelint 'src/**/*.{vue,css,scss}'` glob in the npm scripts may not work as expected on Windows shells due to single-quote handling and glob expansion; consider using double quotes or a cross-platform runner (e.g. `cross-env-shell` or a JS-based glob) if Windows support is needed.
## Individual Comments
### Comment 1
<location> `core/frontend/src/components/autopilot/EndpointCard.vue:203-207` </location>
<code_context>
<style scoped>
.endpoint-buttons {
gap: 8px;
- display: flex;
position: absolute;
right: -16px;
top: 50%;
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing `display: flex` from `.endpoint-buttons` will likely break layout and make `gap` ineffective.
Since `gap` only works on flex/grid containers, this change will both disable the spacing and likely misalign the buttons. If the layout isn’t meant to change, keep `display: flex;` here or apply `gap` to a flex parent instead.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #191
Summary by Sourcery
Add CSS linting to the frontend and clean up styles to satisfy the new rules.
Enhancements:
Build: