vtab-auth#5814

Open

akshatsikarwar wants to merge 5 commits intobloomberg:mainfrom

akshatsikarwar:vtab

Contributor

akshatsikarwar commented Mar 13, 2026

Combines #5769, #5806, #5808

mohitkhullar added 3 commits

March 13, 2026 08:52


          Start using IAM for vtab access

56c97b1

Signed-off-by: mkhullar <mohit.khullar@gmail.com>


          Allow most except in strict vtab mode

ac3343e

Signed-off-by: mkhullar <mohit.khullar@gmail.com>


          Allow option to use passwords with IAM for transition

f3a7131

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

Contributor Author

akshatsikarwar commented Mar 13, 2026

Contributor

mohitkhullar commented Mar 13, 2026

Thanks, added changes for these failures #5808 (review)

mohitkhullar force-pushed the vtab branch from a2f1bc3 to e11f62f Compare

March 13, 2026 13:22

roborivers approved these changes

View reviewed changes

roborivers left a comment

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
cldeadlock
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
queuedb_rollover
reco-ddlk-sql

mohitkhullar previously approved these changes

View reviewed changes

Contributor

mohitkhullar left a comment

lgtm

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
unifiedcancel **quarantined**

mohitkhullar dismissed their stale review via

a41be34

April 13, 2026 17:46

mohitkhullar force-pushed the vtab branch from e11f62f to a41be34 Compare

April 13, 2026 17:46

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
cldeadlock
consumer_non_atomic_default_consumer_generated **quarantined**
simpleauth
reco-ddlk-sql [timeout] **quarantined**


          Keep the password case same | Fix failing tests

25edd79

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

mohitkhullar force-pushed the vtab branch from a41be34 to 25edd79 Compare

April 14, 2026 12:10

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
scindex_logicalsc_generated
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_lotsoftables_logicalsc_generated [db unavailable at finish]
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

mohitkhullar previously approved these changes

View reviewed changes

mohitkhullar dismissed their stale review via

f39795c

April 15, 2026 16:00

mohitkhullar force-pushed the vtab branch 5 times, most recently from 0260e04 to 25d064f Compare

April 15, 2026 17:55

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: 3/191 tests failed ⚠.

The first 10 failing tests are:
delfile_block [setup failed with core dumped]
truncatesc_offline_generated [failed with core dumped] **quarantined**
sc_resume_logicalsc_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
bulkimport_simpleauth
api_tst
simpleauth
alias

mohitkhullar force-pushed the vtab branch from 25d064f to 17ab262 Compare

April 16, 2026 19:34

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
timepart_retro
consumer_non_atomic_default_consumer_generated **quarantined**
simpleauth
insert_lots_ssl_generated [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
scindex_logicalsc_generated
consumer_non_atomic_default_consumer_generated **quarantined**
simpleauth
truncatesc_offline_generated [timeout] **quarantined**


          Check anyways to give warning

2cb448d

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

mohitkhullar force-pushed the vtab branch from 17ab262 to 2cb448d Compare

April 17, 2026 17:48

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_truncate_lockorder_generated [timeout] **quarantined**

roborivers suggested changes

View reviewed changes

roborivers left a comment

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated [failed with core dumped] **quarantined**
sc_redo [failed with core dumped]
sc_resume_logicalsc_generated **quarantined**
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet