Skip to content

fix: tempo slider behavior#122

Open
areohbe wants to merge 3 commits intoblackboxaudio:developfrom
areohbe:fix-tempo-slider
Open

fix: tempo slider behavior#122
areohbe wants to merge 3 commits intoblackboxaudio:developfrom
areohbe:fix-tempo-slider

Conversation

@areohbe
Copy link
Copy Markdown
Contributor

@areohbe areohbe commented Mar 21, 2026

Related Issue

Closes #

Summary (optional)

fixes tempo slider behavior when dragging to 0 instead of using reset button. this wa bc of weirdness in svelte if you try to use bind:value with manual change handlers, this just avoids that weirdness entirely.
...

Checklist

  • Self-reviewed the diff
  • Tested locally
  • No unrelated changes included

@areohbe areohbe marked this pull request as ready for review March 21, 2026 17:50
@maxwellmattryan
Copy link
Copy Markdown
Collaborator

Did you test this locally? I pulled in your changes and it 1) became laggy when changing the slider and more importantly 2) stopped playback every time I adjusted the slider.

@maxwellmattryan maxwellmattryan changed the title tempo slider fix fix: tempo slider behavior Mar 23, 2026
@areohbe
Copy link
Copy Markdown
Contributor Author

areohbe commented Mar 25, 2026

Did you test this locally? I pulled in your changes and it 1) became laggy when changing the slider and more importantly 2) stopped playback every time I adjusted the slider.

hmm odd. i did test locally and it was working fine for me. i'll give it another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants