Open
Conversation
Collaborator
|
Did you test this locally? I pulled in your changes and it 1) became laggy when changing the slider and more importantly 2) stopped playback every time I adjusted the slider. |
Contributor
Author
hmm odd. i did test locally and it was working fine for me. i'll give it another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #
Summary (optional)
fixes tempo slider behavior when dragging to 0 instead of using reset button. this wa bc of weirdness in svelte if you try to use
bind:valuewith manual change handlers, this just avoids that weirdness entirely....
Checklist