[PM-33164] Fix OIDC response_mode to use spec-compliant default#7154
Open
boris324 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-33164] Fix OIDC response_mode to use spec-compliant default#7154boris324 wants to merge 1 commit intobitwarden:mainfrom
boris324 wants to merge 1 commit intobitwarden:mainfrom
Conversation
Change hardcoded response_mode from "form_post" to "query" for external IdP OIDC configurations. Per OpenID Connect Discovery 1.0 spec, the default supported response modes when omitted are "query" and "fragment" - not "form_post". Using "form_post" breaks SSO login with strict IdPs that don't support it and actively reject it. The "query" mode is what Bitwarden already accepts on the callback, so this change aligns the request with actual behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5461
Summary
Changed the hardcoded
response_modefromform_posttoqueryfor external IdP OIDC configurations inDynamicAuthenticationSchemeProvider.Per the OpenID Connect Discovery 1.0 spec, when the
response_modes_supportedfield is omitted from the IdP discovery document, the default supported modes arequeryandfragment— notform_post.This fix resolves SSO login failures with strict IdPs (e.g., Kanidm) that do not support
form_postand actively reject requests using it. Thequerymode is already what Bitwarden accepts on the callback path, so this change aligns the request with actual behavior.Test plan
queryresponse modequeryandform_postresponse_mode=query