[PM-33163] Fix admin panel version fetch error handling#7153
Open
boris324 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-33163] Fix admin panel version fetch error handling#7153boris324 wants to merge 1 commit intobitwarden:mainfrom
boris324 wants to merge 1 commit intobitwarden:mainfrom
Conversation
Improve GetInstalledWebVersion to catch all failure scenarios: - TaskCanceledException for request timeouts - JsonException/KeyNotFoundException for malformed responses - Log warning when HTTP response is non-successful instead of silently returning "-" Previously only HttpRequestException was caught, so timeouts and parse errors behind reverse proxies would result in unhandled exceptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7142
Summary
Improved error handling in
GetInstalledWebVersionto catch all failure scenarios that occur behind reverse proxies:Previously only
HttpRequestExceptionwas caught, so timeouts and parse errors would result in unhandled exceptions, leaving the version display stuck on the spinner.Test plan