Revert "Revert "Auth/PM-3287 - Remove deprecated ResetMasterPassword property from IdentityTokenResponse""#7152
Open
JaredSnider-Bitwarden wants to merge 3 commits intomainfrom
Conversation
…e deprec…" This reverts commit e6c97bd.
…anup-remove-reset-master-password-from-token-response
…76-auth/pm-3287/tde-cleanup-remove-reset-master-password-from-token-response
rr-bw
approved these changes
Mar 4, 2026
JaredSnider-Bitwarden
removed the request for review
from Patrick-Pimentel-Bitwarden
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7152 +/- ##
========================================
Coverage 56.68% 56.69%
========================================
Files 2023 2026 +3
Lines 88571 88676 +105
Branches 7897 7904 +7
========================================
+ Hits 50204 50271 +67
- Misses 36541 36581 +40
+ Partials 1826 1824 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6755
Which re-applies the changes from #6676 and https://bitwarden.atlassian.net/browse/PM-3287.
We must await mobile releases on both ios and android to ensure we do not break login for them (i.e., the
resetMasterPasswordproperty must be made optional / removed on those clients).Re-opening b/c github exploded with #6756 and wouldn't let me merge it or re-open it after closing it.