[PM-33154] Fix: Handle mail server DNS errors on admin login#7150
Open
boris324 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-33154] Fix: Handle mail server DNS errors on admin login#7150boris324 wants to merge 1 commit intobitwarden:mainfrom
boris324 wants to merge 1 commit intobitwarden:mainfrom
Conversation
When the SMTP host DNS is misconfigured, SocketException propagates unhandled from MailKit through LoginController.Index(), resulting in a confusing 404 page. Wrap the passwordless sign-in call in a try/catch to log the error and display a clear message instead. Resolves bitwarden#6792
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SocketExceptionpropagates unhandled fromMailKit.Net.Smtp.SmtpClient.ConnectAsync()throughLoginController.Index(), resulting in a confusing 404 error pagePasswordlessSignInAsync()to catch the exception, log it, and redirect with a clear error messageILogger<LoginController>for proper error loggingTest plan
globalSettings__mail__smtp__hostto non-existent hostname/admin/and enter email address