[PM-33151] Fix: Register NoopBusinessUnitConverter for OSS builds#7147
Open
boris324 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-33151] Fix: Register NoopBusinessUnitConverter for OSS builds#7147boris324 wants to merge 1 commit intobitwarden:mainfrom
boris324 wants to merge 1 commit intobitwarden:mainfrom
Conversation
IBusinessUnitConverter is only registered in the Commercial module. When compiled with OSS flag, the DI container cannot resolve it for OrganizationBillingController. Register a no-op implementation in AddOosServices() following the existing Noop pattern. Resolves bitwarden#6292
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBusinessUnitConverterwas only registered in the Commercial module, causingInvalidOperationExceptionwhen compiled with OSS flagNoopBusinessUnitConverterfollowing the existing Noop pattern (e.g.NoopProviderService)AddOosServices()inServiceCollectionExtensions.csTest plan