Skip to content

Update writing-database-queries skill#56

Merged
rkac-bw merged 7 commits intomainfrom
ai/update-writing-database-queries-skill
Apr 16, 2026
Merged

Update writing-database-queries skill#56
rkac-bw merged 7 commits intomainfrom
ai/update-writing-database-queries-skill

Conversation

@rkac-bw
Copy link
Copy Markdown
Contributor

@rkac-bw rkac-bw commented Feb 25, 2026

Draft: updating
writing-database-queries skill content

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 25, 2026

Logo
Checkmarx One – Scan Summary & Details0a83f51a-f1fe-4a22-b66c-efbe9913d4a4

Great job! No new security vulnerabilities introduced in this pull request

@theMickster theMickster self-requested a review February 26, 2026 14:49
@theMickster theMickster marked this pull request as ready for review March 3, 2026 07:07
@theMickster theMickster requested a review from a team as a code owner March 3, 2026 07:07
@theMickster theMickster marked this pull request as draft March 3, 2026 07:20
@theMickster
Copy link
Copy Markdown
Contributor

Note I intentionally published with the intent of going back to draft state to test the [Validate plugin structure and requirements](https://github.com/bitwarden/ai-plugins/actions/runs/22415232179/job/65517277756?pr=56#logs) action. I think we have work to do to extend it because I expected a validation warning about version bumping and I didn't see it when the PR was in draft nor in published state. Task for another day though 😕

Copy link
Copy Markdown
Contributor

@theMickster theMickster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 All changes need to bump the plugin's version. The change is rather small so a patch bump feels most appropriate. On your local workstation, in the ai-plugins folder, you will execute the following:

./scripts/bump-plugin-version.sh bitwarden-software-engineer <next-patch-version>

🛑 All changes need an entry in plugins/bitwarden-software-engineer/CHANGELOG.md.

Suggested entry under ### Changed:

  • Updated writing-database-queries skill: clarified dual-ORM architecture, rewrote EDD section to reflect no-rollback deployment model, documented stored procedure compatibility patterns, and simplified key locations.

Comment thread plugins/bitwarden-software-engineer/skills/writing-database-queries/SKILL.md Outdated
Comment thread plugins/bitwarden-software-engineer/skills/writing-database-queries/SKILL.md Outdated
rkac-bw added 2 commits March 5, 2026 13:19
Address PR #56 review feedback: add version bump and changelog
entry for writing-database-queries skill update.
@rkac-bw rkac-bw requested a review from theMickster March 5, 2026 20:28
- Remove "For example" prefix from stored procedure section
- Update critical rule to match dual-ORM exceptions documented above
Copy link
Copy Markdown
Contributor

@theMickster theMickster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small, but I think, important wording change and I think we are good to publish & likely merge.

Comment thread plugins/bitwarden-software-engineer/skills/writing-database-queries/SKILL.md Outdated
@rkac-bw rkac-bw marked this pull request as ready for review April 15, 2026 16:29
@rkac-bw rkac-bw requested a review from theMickster April 15, 2026 16:29
Copy link
Copy Markdown
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one oversight and then this is good.

Comment thread .claude/settings.local.json Outdated
@@ -0,0 +1,5 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Remove.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@rkac-bw rkac-bw merged commit 031533d into main Apr 16, 2026
17 checks passed
@rkac-bw rkac-bw deleted the ai/update-writing-database-queries-skill branch April 16, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants