feat(core,chain): implement Display, FromStr, FromSql and ToSql for BlockId
#2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
3 tasks
Contributor
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
Concept ACK
It looks good, though I want to test it with the bdk_wallet companion PR before fully ACK'ing it.
Contributor
|
Also, the PR description is missing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Display,FromStrforBlockId, andFromSqlandToSqlforImpl<BlockId>, needed to persist the wallet's birthday as aBlockId(height + hash).Changelog notice
DisplayandFromStrforBlockIdFromSqlandToSqlforImpl<BlockId>