fix: restore analytics user password via shell interpolation#17
Merged
Conversation
The \getenv + psql variable approach introduced by the auto-fix review does not work reliably in a heredoc context, leaving the password unset after the restore job clears all role passwords. ANALYTICS_PASSWORD is generated by the operator (generate_password in replica.rs) and stored in a Kubernetes secret - it is not user-controlled input, so shell interpolation into the SQL string is safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
\getenv+ psql variable approach (:'analytics_password') introduced by an auto-fix review suggestion on #15 does not work reliably in a heredoc context. The result is that the password set by\getenvis either empty or not applied, and since the restore job clears all role passwords before this block runs, the analytics user ends up with no password and can't log in.Reverts to shell variable interpolation (
'${ANALYTICS_PASSWORD}'). This is safe becauseANALYTICS_PASSWORDis generated by the operator (generate_passwordinreplica.rs) and stored in a Kubernetes secret — it is not user-controlled input. A comment explaining this is added inline.To fix an affected instance manually:
ALTER ROLE analytics WITH PASSWORD '<password from creds secret>';🦸 Review Hero