[BUGFIX] Adapt use of removed ViewHelper in EXT:indexed_search#1537
Open
garvinhicking wants to merge 1 commit intobenjaminkott:masterfrom
Open
[BUGFIX] Adapt use of removed ViewHelper in EXT:indexed_search#1537garvinhicking wants to merge 1 commit intobenjaminkott:masterfrom
garvinhicking wants to merge 1 commit intobenjaminkott:masterfrom
Conversation
With https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102945-PaginationOfIndexedSearchReplaced.html the ViewHelpers `is:pageBrowsingResults` and `is:pageBrowsing` have been removed. bootstrap_package for TYPO3 v13 needs adaption to prevent a PHP error when using the adapted indexed_search template. This has also been reported with: * https://forge.typo3.org/issues/105562 * FriendsOfTYPO3/introduction#115 The latter needs to be updated to a new release of EXT:bootstrap_package once this bugfix has been merged. I do not know / did not check, if this template would work in TYPO3 v12, so maybe a different template needs to be used for TYPO3 v12. Releases: master, 15.x
garvinhicking
changed the title
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102945-PaginationOfIndexedSearchReplaced.html the ViewHelpers
is:pageBrowsingResultsandis:pageBrowsinghave been removed.bootstrap_package for TYPO3 v13 needs adaption to prevent a PHP error when using the adapted indexed_search template.
This has also been reported with:
The latter needs to be updated to a new release of EXT:bootstrap_package once this bugfix has been merged.
I do not know / did not check, if this
template would work in TYPO3 v12, so maybe a different template needs to be used for TYPO3 v12.
Releases: master, BP 15.x