Introduce notFalse()#274
Open
simPod wants to merge 2 commits intobeberlei:masterfrom
simPod:not-false
Open
Conversation
|
I'd very much appreciate this addition! Would it be accepted if I supplied an update to date PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was rewriting this code
into Assertion and the
Assertion::notFalse()method was missing. UsingAssertion::true($filename !== false)IMO loses the benefit of using Assertion as nice readable wrappers around simple conditions.notFalse()is similar tonotNull(). Especially some PHP internal functions return type of<result>|boolbut actuallyboolthere isfalse-><result>|falsewhich stands for failure. This is handy instrument how to handle it.