Fix Strings.split() to handle delimiters at position 0 #2244
+69
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The split method incorrectly treated delimiters at index 0 as 'no delimiter
found' because the condition used 'tokenLocation > 0' instead of '>= 0'.
This caused issues in PKIXNameConstraintValidator.withinDomain() when
processing DNS name constraints with leading dots (e.g., '.example.com').
The method would return the entire string as a single element instead of
properly splitting it, causing certificate validation to fail when both
Root CA and Subordinate CA had the same dNSName in NameConstraints.
Fix: Change 'tokenLocation > 0' to 'tokenLocation >= 0'
Before: Strings.split(".permitted", '.') -> [".permitted"]
After: Strings.split(".permitted", '.') -> ["", "permitted"]
Fixes: bcgit#1481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1481
The split method incorrectly treated delimiters at index 0 as 'no delimiter found' because the condition used 'tokenLocation > 0' instead of '>= 0'.
This caused issues in PKIXNameConstraintValidator.withinDomain() when processing DNS name constraints with leading dots (e.g., '.example.com'). The method would return the entire string as a single element instead of properly splitting it, causing certificate validation to fail when both Root CA and Subordinate CA had the same dNSName in NameConstraints.
Fix: Change 'tokenLocation > 0' to 'tokenLocation >= 0'
Before: Strings.split(".permitted", '.') -> [".permitted"]
After: Strings.split(".permitted", '.') -> ["", "permitted"]