Skip to content

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Jan 8, 2026

This PR fixes passing of global datatree attributes to children. Attributes defined on parent datatrees are now inherited by all descendants.

Closes #63.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.48%. Comparing base (353e655) to head (e27d640).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files          74       74           
  Lines        2927     2932    +5     
  Branches      425      425           
=======================================
+ Hits         2912     2917    +5     
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clarasb clarasb marked this pull request as ready for review January 12, 2026 11:47
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix:

  • It is not clear, why the fix is correct. New code is also quite unintuitive.
  • Missing unit tests

@clarasb clarasb requested a review from forman January 27, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attributes from parent group not recognized

3 participants