Fix self-contained (bundled) linker in hermetic sandbox#3896
Closed
trchen1033 wants to merge 1 commit intobazelbuild:mainfrom
Closed
Fix self-contained (bundled) linker in hermetic sandbox#3896trchen1033 wants to merge 1 commit intobazelbuild:mainfrom
trchen1033 wants to merge 1 commit intobazelbuild:mainfrom
Conversation
rustc looks for its bundled linker in target-specific path, e.g. `lib/rustlib/x86_64-unknown-linux-gnu/bin/rust-lld` But it is installed into `bin/rust-lld` in the generated sysroot instead. This resulted in rustc errors durning linking such as ``` error: the self-contained linker was requested, but it wasn't found in the target's sysroot, or in rustc's sysroot ``` This patch makes rust-lld to be installed in both bin and its original path.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
NVM, this patch is only needed in 0.69 release. This is already fixed in main and the patch will cause a conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc looks for its bundled linker in target-specific path, e.g.
lib/rustlib/x86_64-unknown-linux-gnu/bin/rust-lldBut it is installed into
bin/rust-lldin the generated sysroot instead. This resulted in rustc errors durning linking such asThis patch makes rust-lld to be installed in both bin and its original path.