refactor: rename files_to_build to default_outputs

[rickeylev]

The "files to build" term is the jargon used with the Bazel Java code, but
in regular Starlark code, the term is "default outputs". This jargon leakage
happened while porting the code from Java to Starlark.

[gemini-code-assist]

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring effort to improve code clarity and consistency by standardizing terminology within the Starlark codebase. It replaces the "files to build" concept, which originated from Bazel Java, with the more appropriate "default outputs" term used in Starlark. This change involves renaming variables, updating function calls, and adjusting related test cases to ensure the codebase adheres to native Starlark conventions.

Highlights

• Terminology Alignment: The term files_to_build has been renamed to default_outputs across the codebase to align with standard Starlark terminology and avoid jargon originating from Bazel Java code.
• Function Removal: The create_executable_result_struct function and its associated calls have been removed, as its functionality is now directly integrated into struct creation.
• Test Updates: Corresponding test functions and variables in py_executable_base_tests.bzl and py_library_tests.bzl were updated to reflect the new default_outputs terminology.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a refactoring that renames files_to_build to default_outputs to align with standard Starlark terminology, removing jargon from Bazel's Java implementation. The changes are consistent across the codebase, including variable names, function names in tests, and fields in data structures. The create_executable_result_struct helper function has been removed and its logic inlined at the call site, which simplifies the code. The changes are well-contained and improve code clarity. I have no further comments.