chore: remove testing of Bazel 7 #3541
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's testing infrastructure to reflect the new minimum supported Bazel version, moving from Bazel 7 to Bazel 8. This change is in response to Bazel 7 reaching end-of-life with the recent release of Bazel 9. The modifications primarily involve updating CI configurations, removing Bazel 7 binary dependencies, and cleaning up version-specific flags in test setups. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes testing for Bazel 7, which is now out of support, and establishes Bazel 8 as the new minimum supported version. The changes are consistent across the CI configuration files and Bazel module definitions, correctly updating version numbers and removing obsolete settings. I have one point of feedback regarding a TODO comment that seems to conflict with a change in the CI configuration, which could potentially impact CI stability.
| # TODO @aignas 2024-12-11: get the RBE working in CI for bazel 8.0 | ||
| # See https://github.com/bazelbuild/rules_python/issues/2499 | ||
| bazel: 7.x | ||
| bazel: 8.x |
There was a problem hiding this comment.
The Bazel version is updated to 8.x, but the comment on the preceding lines (283-284) mentions a known issue with Bazel 8.0 on RBE. Has this issue been resolved? If so, it would be good practice to also remove the TODO comment to avoid confusion. If the issue is still present, this change might cause CI failures.
2 participants
With the release of Bazel 9, Bazel 7 moves out of support and Bazel 8 becomes the
lowest supported version.
DO NOT MERGE: Bazel 9 came out only about 4 days ago. I want to wait 1 rules_python release
(about 1 month) before removing testing with Bazel 7. e.g. release 1.9 in Feb with bazel 7 support, remove bazel 7 testing, then release 1.10 (March) without official bazel 7 support.