feat: add package metadata for wheel libraries #3531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add package_metadata rule to generated BUILD files for wheel libraries to track package provenance using PURL (Package URL) format.
stevebarrau
requested review from
aignas,
groodt and
rickeylev
as code owners
aignas
reviewed
Jan 23, 2026
python/private/pypi/whl_library.bzl
Outdated
| entry_points[entry_point_without_py] = entry_point_script_name | ||
|
|
||
| namespace_package_files = pypi_repo_utils.find_namespace_package_files(rctx, rctx.path("site-packages")) | ||
| purl = "pkg:pypi/{}@{}".format( |
Collaborator
There was a problem hiding this comment.
What happens if we have private packages in here? Is pkg:pypi/{}@{} only a type of registry or the actual public PyPI?
Author
There was a problem hiding this comment.
IIUC registry information is not yet present in the metadata object, right? IIUC the most common approach is to have an --index-url instruction in the requirements_lock file. DO you know where I can fish out this information from within the rules?
python/private/pypi/whl_library.bzl
Outdated
| "pypi_version={}".format(metadata["version"]), | ||
| ], | ||
| namespace_package_files = namespace_package_files, | ||
| purl = purl, |
Collaborator
There was a problem hiding this comment.
This also needs to be added above, in the other branch of the code.
Collaborator
|
What are other things that are needed for #2054 to be resolved? |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add package_metadata rule to generated BUILD files for wheel libraries to track package provenance using PURL (Package URL) format.
This is then picked up by supply_chain_tools to produce SBOM for python target using external dependencies.