Conversation
There was a problem hiding this comment.
Pull request overview
Adds CLI support for publishing/unpublishing Fizzy boards, and wires the new behavior through docs, surface area tracking, unit tests, and e2e coverage.
Changes:
- Introduces
fizzy board publishandfizzy board unpublishcommands hitting the board publication endpoints. - Updates
board showto surface publish/unpublish as the next suggested action based onpublic_url. - Extends unit tests, board e2e tests, and updates surfaced CLI metadata/docs (including fixing the e2e harness global flag from
--accountto--profile).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/board.go |
Adds publish/unpublish commands and augments board show breadcrumbs. |
internal/commands/board_test.go |
Adds unit tests for publish/unpublish command behavior. |
e2e/tests/board_test.go |
Adds publish/unpublish coverage with a skip path for incomplete live API rollout. |
e2e/harness/harness.go |
Updates harness to pass --profile (current flag) instead of stale --account. |
skills/fizzy/SKILL.md |
Documents new board publication commands and behavior. |
internal/skills/SKILL.md |
Mirrors skill documentation updates for internal usage. |
SURFACE.txt |
Records new commands/flags in the CLI surface area inventory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robzolkos
force-pushed
the
board-publication-support
branch
2 times, most recently
from
f01cfd6 to
7c14d98
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robzolkos
force-pushed
the
board-publication-support
branch
from
7c14d98 to
b55d85b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Columns in list commands were rendering with no gap between them, making values hard to distinguish. Add right padding to table cells so columns have breathing room.
Pre-build headerStyle and cellStyle with PaddingRight(1) instead of allocating new styles on each StyleFunc invocation.
- Fix double unpublish in e2e test by tracking published state so cleanup only runs when the explicit in-test unpublish hasn't already executed - Add unit tests for board show publish/unpublish breadcrumb behavior - Switch board show from typed Boards().Get() to raw ac.Get() so public_url (not yet in SDK Board struct) is preserved in the response
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="e2e/tests/board_test.go">
<violation number="1" location="e2e/tests/board_test.go:194">
P2: `published = false` is set before verifying the unpublish succeeded. If the command returns a non-success exit code, the cleanup won't retry the unpublish, leaving the board published in the test environment. Move the assignment after the success check.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Ensures cleanup retries unpublish if the command fails mid-test.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prevents cleanup from attempting unpublish when publish itself failed.
Summary
board publishandboard unpublishcommands for board publication endpointsboard showSURFACE.txt--profileflag from e2e harness (already set viaFIZZY_PROFILEenv var)Testing
make checkgo test -v ./e2e/tests -run 'TestBoard'