Skip to content

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 15, 2026

  • Moves flashblock extension to base-flashblocks-node crate. Configuration stays in flashblock lib crate.
  • Updates node to depend on flashblocks-node instead

This allows base-client-engine to depend on flashblocks state and also inject the engine into addons in the flashblock extension. Previously, this would have caused an import cycle.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 15, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@meyer9 meyer9 marked this pull request as draft January 15, 2026 00:10
@meyer9 meyer9 force-pushed the meyer9/separate-flashblocks-extension-crate branch from ba08a84 to 7e7f766 Compare January 15, 2026 00:11
@meyer9
Copy link
Contributor Author

meyer9 commented Jan 15, 2026

oh maybe we can move test harness, benches, and tests back to the original crate... fixed

@meyer9 meyer9 force-pushed the meyer9/separate-flashblocks-extension-crate branch from 7e7f766 to 632642b Compare January 15, 2026 00:22
@meyer9 meyer9 marked this pull request as ready for review January 15, 2026 00:22
@meyer9 meyer9 requested review from danyalprout and refcell January 15, 2026 00:23
@meyer9
Copy link
Contributor Author

meyer9 commented Jan 15, 2026

Will wait for 2 reviews to merge since this is a crate reorganization

@meyer9 meyer9 requested a review from haardikk21 January 15, 2026 00:24
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, can always rename later!

@haardikk21 haardikk21 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit b03e934 Jan 15, 2026
15 checks passed
@haardikk21 haardikk21 deleted the meyer9/separate-flashblocks-extension-crate branch January 15, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants