chore(builder): remove flashblocks extra context #448
+118
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
haardikk21
requested changes
Jan 14, 2026
| Pool: PoolBounds, | ||
| Client: ClientBounds, | ||
| { | ||
| #[allow(clippy::too_many_arguments)] |
Collaborator
There was a problem hiding this comment.
ah i dont love this, but i guess its fine for now
Farukest
force-pushed
the
chore/remove-flashblocks-extra-context
branch
from
8a04383 to
f625850
Compare
Contributor
Author
All done @haardikk21 let me know if anything else needs |
haardikk21
previously approved these changes
Jan 14, 2026
Collaborator
haardikk21
left a comment
haardikk21
left a comment
There was a problem hiding this comment.
LGTM, will wait for another review before merge
Remove FlashblocksExtraCtx struct and inline its fields directly into OpPayloadBuilderCtx. This simplifies the code by eliminating an unnecessary layer of indirection. - Move all FlashblocksExtraCtx fields into OpPayloadBuilderCtx - Replace with_extra_ctx() with with_next_targets() - Update all ctx.extra.xxx usages to ctx.xxx - Return tuple instead of struct from build_next_flashblock() - Remove redundant flashblock_index() and target_flashblock_count() getters Closes base#443
Farukest
force-pushed
the
chore/remove-flashblocks-extra-context
branch
from
f625850 to
5f82ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
FlashblocksExtraCtxstruct and inline its fields directly intoOpPayloadBuilderCtx. This eliminates an unnecessary layer of indirection since flashblocks is now the only builder mode.Changes
FlashblocksExtraCtxfields intoOpPayloadBuilderCtxwith_extra_ctx()withwith_next_flashblock()ctx.extra.xxxusages toctx.xxxbuild_next_flashblock()Test plan
cargo check -p op-rbuilderpassescargo check -p op-rbuilder --testspassesCloses #443