feat(hook): one-click clear-context + bypass via native plan-accept + keystroke injection#693
Open
AgileInnov8tor wants to merge 7 commits into
Open
feat(hook): one-click clear-context + bypass via native plan-accept + keystroke injection#693AgileInnov8tor wants to merge 7 commits into
AgileInnov8tor wants to merge 7 commits into
Conversation
Thread a clear-context reminder flag through approval decisions, expose a Claude Code-only approval entry that requests bypass mode, and keep the hook response honest by emitting a reminder instead of claiming context was cleared. Constraint: Claude Code PermissionRequest hooks have no documented clearContext response field and bypassPermissions is only a request when the mode is available. Rejected: adding a permission-mode enum or undocumented clearContext field | those would misrepresent hook capabilities and broaden the contract. Confidence: high Scope-risk: moderate Directive: Do not claim Plannotator clears context until Claude Code documents a hook field for that behavior; keep reminder copy truthful. Tested: bun test packages/server apps/hook; bun test packages/editor/wideMode.test.ts packages/ui/hooks/useAgentSettings.test.ts; bun test; bun run build:review; bun run build:hook; bun run typecheck; git diff --check --cached. Not-tested: Browser warning-dialog replay and interactive Claude Code smoke test. Co-authored-by: OmX <omx@oh-my-codex.dev>
Constraint: Claude Code hooks cannot clear context directly; the new action remains a truthful reminder plus bypass-mode approval. Rejected: Sending OpenCode agent-switch state for Claude Code | it leaked build (?) UI state and misleading payload fields. Confidence: high Scope-risk: narrow Directive: Keep OpenCode agent switching gated to opencode-origin approval payloads. Tested: bun run typecheck; bun test; bun run build:review; bun run build:hook Not-tested: Manual browser click-through of the Claude Code dropdown.
Route Claude Code plan approvals through explicit bypass payloads, consent-gated native clear-context deferral, and a fallback /clear nudge so selecting the clear-context mode no longer collapses into a silent approval no-op. The active ignored hook bundle was rebuilt locally after this source change. Constraint: Claude Code hooks cannot directly clear context; native clear requires showClearContextOnPlanAccept and user consent.\nRejected: Treating bypassPermissionsClearReminder as a raw permissionMode | Claude Code only accepts bypassPermissions on the wire and would ignore the local UI-only value.\nConfidence: high\nScope-risk: moderate\nDirective: Rebuild apps/hook/dist/index.html after changing plan-review UI because the local plannotator launcher imports the ignored dist bundle at runtime.\nTested: git diff --check; bun run typecheck; bun test; bun run build:review; bun run build:hook; fixed-port hook smoke for /api/settings-status and native-clear /api/approve.\nNot-tested: Manual click-through in Claude Code native plan-accept dialog.
…ction
When user clicks "Approve + Bypass + Clear Context (native)" in plannotator
UI, the hook now spawns a detached background process before exiting 0
(native passthrough). The process injects "1\n" into the CC terminal after
a 600ms delay, auto-selecting "Yes, clear context and bypass permissions"
without a manual keypress.
Detection priority:
1. tmux ($TMUX_PANE) → tmux send-keys (no accessibility permissions needed)
2. macOS → osascript iterating {warp, iTerm2, Terminal}
3. Linux/Windows without tmux → no-op (falls back to manual press)
spawnKeystrokeInjector() detaches via Bun.spawn + .unref() — parent exits
immediately, child fires after delay.
7 unit tests added (265/265 pass). Build clean. Smoke-tested on WarpTerminal.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…pawn Structural cleanup of the keystroke injector without behavior changes: - Delete 16-line module docblock + 5-line JSDoc (over-commented for 78 lines) - Inline buildTmuxScript() and buildOsascriptScript() — single-use helpers - Unify the duplicated Bun.spawn+.unref() into one call at the end: both branches now set `script: string | null`, then a single spawn runs if set - `KNOWN_MACOS_TERMINALS as const` → plain string[] (not a readonly tuple) Test cleanup: - Extract setPlatform(v) helper — replaces 5× Object.defineProperty blocks 78→39 lines (implementation), 118→107 lines (tests). 7/7 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Warp ships as Warp.app/Contents/MacOS/stable, so its macOS process name is "stable" — not "warp". The previous code checked `exists (application process "warp")` via System Events, which always returned false on Warp, leaving the keystroke never injected and the CC plan-accept TUI unattended. Fix: check `application "Warp" is running` (bundle-name lookup, works regardless of the binary name) and activate Warp directly before sending keystrokes. Fall through to process-name search for iTerm2 and Terminal unchanged. Test: update the osascript assertion to match the new Warp check. 7/7 tests pass. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Constraint: Approved Ralph plan required saved bypassPermissionsClearReminder to nudge /clear without native fresh-thread deferral.\nRejected: Reusing native clear as the default | it can restart or open a fresh thread unexpectedly.\nConfidence: high\nScope-risk: moderate\nDirective: Treat deferToNativeForClear as an explicit native/fresh-thread escape hatch only; do not wire it to saved reminder mode.\nTested: bun test packages/editor/approvalBody.test.ts apps/hook/server/keystrokeInjector.test.ts; git diff --check scoped files; bun run typecheck; bun test; bun run build:hook; architect verification approved.\nNot-tested: Interactive manual browser smoke of Claude Code native dialog selection.
Owner
Can you explain what do you mean by this? 'Cause right now it's all automated. You just approve and the agent goes on. |
Contributor
Author
|
The "before" is specific to the "Approve + Bypass + Clear Context (native)" option, not the standard approve flow which is already zero keystrokes. Background: |
Owner
|
Okay, I think I understand. So this would require the user to turn that on and then Instead of auto approving the plan, it just pauses and then the user gets the option to clear context. |
Contributor
Author
|
Yes exactly
…On Wed, May 13, 2026 at 6:54 PM Michael Ramos ***@***.***> wrote:
*backnotprop* left a comment (backnotprop/plannotator#693)
<#693 (comment)>
Okay, I think I understand. So this would require the user to turn that on
and then Instead of auto approving the plan, it just pauses and then the
user gets the option to clear context.
—
Reply to this email directly, view it on GitHub
<#693 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6N5X7P3XGL43VUBYHD2QLT42RPAHAVCNFSM6AAAAACYYQNQ4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINBQGY3DIOBYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proper replacement for the reverted PR #668 (Expose bypass clear reminder permission mode).
PR #668 was reverted because the hook emitted a
/clearreminder that was never actually displayed — a silent no-op. This PR takes a different approach: instead of trying to do the impossible (hooks cannot clear context directly), it defers to Claude Code's own native primitive.What changed
Four commits:
Wire truthful approval semantics (9096eff, c7727b9) — thread
permissionModeand a newdeferToNativeForClearflag through the decision pipeline so the hook knows when to defer vs. when to nudge.Consent-gated native deferral (ff79946) — when user picks "Approve + Bypass + Clear Context (native)":
showClearContextOnPlanAccept: trueto~/.claude/settings.json(consent-gated, atomic write with retry)Keystroke injection for one-click UX (12cddf7,
apps/hook/server/keystrokeInjector.ts) — before exiting 0, spawn a detached background process that fires "1\n" into the CC terminal after 600ms:$TMUX_PANE):tmux send-keys -t <pane> 1 Enter(no accessibility permissions needed)osascriptiterating{warp, iTerm2, Terminal}via System EventsSlop cleanup (fb6c44d) — no behavior change; removes AI-generated bloat from keystrokeInjector:
keystrokeInjector.ts78→39 lines: delete 16-line module docblock + 5-line JSDoc; inline two single-use builder functions; unify the duplicatedBun.spawn+.unref()into a single callkeystrokeInjector.test.ts118→107 lines: extractsetPlatform(v)helper replacing 5× repeatedObject.definePropertyblocksWhy not a hook
clearContextfield?CC's
updatedPermissionstypes areaddRules/setMode/removeRules. There is noclearContextentry (verified by exhaustive string scan of the CC 2.1.138 binary). The plan-accept TUI dialog is hardcoded in CC's React renderer and cannot be bypassed from a hook. The native passthrough + keystroke injection is the only viable path that preserves true context-clearing without patching CC.User experience
Before: Review plan in plannotator → click → still have to press "1" in terminal
After: Review plan in plannotator → click "Approve + Bypass + Clear Context (native)" → context cleared, bypass mode set, plan executes — zero additional keystrokes
Test plan
bun test packages/server packages/editor apps/hook— 265/265 passbun run build:hook— clean buildNotes
~/.plannotator/consent/clear-context-setting.jsonshowClearContextOnPlanAcceptsetting defaults tofalsein CC (changelog: "hidden by default in plan mode"); this PR turns it on consent-gated, not globally🤖 Generated with Claude Code