Send content-length header in method responses#132
Send content-length header in method responses#132chfritz wants to merge 1 commit intobaalexander:masterfrom
Conversation
- unlike method calls (client), method responses (server) did not yet send content-length headers. This was causing problem with at least one client (ros's turtlesim, in the context of rosnodejs: publishing to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes that.
|
Hi, there! |
|
@agladkov We would love to see this patch pushed. Are there any actual objections? |
|
I have no objections. |
|
@baalexander @patricklodder Any chance you guys can merge this and update the published npm package? We are dependent on a downstream package (https://www.npmjs.com/package/rosnodejs) and I would hate to have to fork both projects for a 1 line change. Thanks. |
|
I need that change as well! |
|
@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change |
@chfritz perfect thank you! |
5 participants
send content-length headers. This was causing problem with at least
one client (ros's turtlesim, in the context of rosnodejs: publishing
to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes
that.