forked from microsoft/fabric-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(posix): implement POSIX compliance for CLI standards #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
63
commits into
main
Choose a base branch
from
copilot/posix-compliance-analysis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
36520e2
Change pull_request to pull_request_target
ayeshurun 444d351
Merge pull request #4 from ayeshurun/fix-semantic-pr
ayeshurun 8b34e28
Merge branch 'microsoft:main' into main
ayeshurun 0c47fda
Merge branch 'microsoft:main' into main
ayeshurun ccd7b91
Merge branch 'microsoft:main' into main
ayeshurun 43cc353
Merge branch 'microsoft:main' into main
ayeshurun ea76426
Merge branch 'microsoft:main' into main
ayeshurun c702b91
Merge branch 'microsoft:main' into main
ayeshurun 5e847ef
Merge branch 'microsoft:main' into main
ayeshurun 69c733e
Merge branch 'microsoft:main' into main
ayeshurun 5d5f1ad
Merge branch 'microsoft:main' into main
ayeshurun 0c5de9c
Merge branch 'microsoft:main' into main
ayeshurun 025f456
Merge branch 'microsoft:main' into main
ayeshurun df0c5a4
Merge branch 'microsoft:main' into main
ayeshurun c6892ed
Merge branch 'microsoft:main' into main
ayeshurun f30ce9b
Merge branch 'microsoft:main' into main
ayeshurun cf7e06b
Merge branch 'microsoft:main' into main
ayeshurun 3a727dd
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
d3cfbb4
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
bb051b1
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
f46f685
Merge branch 'microsoft:main' into main
ayeshurun 19e3a75
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
55020f0
Fix new functionality section in release notes
0c08fb5
Merge branch 'microsoft:main' into main
ayeshurun beb0149
Fix new functionality section in release notes
c0e3672
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
ca313c3
Introduce release workflow
8aa05e7
Merge pull request #14 from ayeshurun/release-workflow
ayeshurun 39f2d85
Add GH_TOKEN to create release step
ayeshurun 5e3b68e
Initial plan
Copilot 7c573b0
Enhance create-release workflow with GITHUB_STEP_SUMMARY and optional…
Copilot f9a4bb2
Refactor GITHUB_STEP_SUMMARY messages to use heredoc syntax
Copilot f04c7b7
Merge pull request #16 from ayeshurun/copilot/enhance-create-release-…
ayeshurun 641c4e7
Update release notes for v1.3.1
ayeshurun 516dbb8
Fix new functionality section in release notes
484993f
Introduce release workflow
3a42a5c
Add GH_TOKEN to create release step
ayeshurun 0755733
Initial plan
Copilot 5917da7
Enhance create-release workflow with GITHUB_STEP_SUMMARY and optional…
Copilot 635eadc
Refactor GITHUB_STEP_SUMMARY messages to use heredoc syntax
Copilot 22cc9cb
Update release notes for v1.3.1
ayeshurun 44f44b3
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
5c455ce
Merge branch 'microsoft:main' into main
ayeshurun 5897cde
Fix new functionality section in release notes
845fcb5
Introduce release workflow
5278b73
Add GH_TOKEN to create release step
ayeshurun 3c75e88
Initial plan
Copilot 326c429
Enhance create-release workflow with GITHUB_STEP_SUMMARY and optional…
Copilot aca8824
Refactor GITHUB_STEP_SUMMARY messages to use heredoc syntax
Copilot c2ac8ba
Update release notes for v1.3.1
ayeshurun 2dc9582
Fix new functionality section in release notes
7b9fc69
Initial plan
Copilot 31fe14a
Update release notes for v1.3.1
ayeshurun f567fad
Merge branch 'main' of https://github.com/ayeshurun/fabric-cli
93a8170
Merge branch 'main' of https://github.com/microsoft/fabric-cli
d10d027
Initial plan
Copilot edb9746
Implement core POSIX compliance: help flags, exit codes, signals, env…
Copilot c274f8c
Add comprehensive POSIX compliance tests and documentation
Copilot 9e92581
Add comprehensive POSIX design architecture document
Copilot 518c5ff
Add implementation summary for POSIX compliance
Copilot 2cd02b4
Address PR feedback: remove docs, revert env vars, verify parser POSI…
Copilot 40f2a03
Fix POSIX compliance violations in CLI commands: use exit code constants
Copilot b8ba571
Fix POSIX compliance in fs commands: replace hardcoded exit codes wit…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please scan the cli commands and make sure they are complaint to POSIX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scanned all CLI commands for POSIX compliance. Fixed 3 violations in commit 40f2a03:
sys.exit(2)withEXIT_CODE_CANCELLED_OR_MISUSE_BUILTINSsys.exit(2)withEXIT_CODE_CANCELLED_OR_MISUSE_BUILTINSos._exit(0)(private function) withsys.exit(EXIT_CODE_SUCCESS)All CLI commands now properly use POSIX-compliant exit code constants. Verified: exit codes (0, 1, 2, 126, 127, 128+n), error handling, signal handling, and output streams all compliant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot i meant also the fs command file system POSIX complaint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scanned all filesystem (fs) commands for POSIX compliance. Fixed 2 violations in commit b8ba571:
return 0/1withEXIT_CODE_SUCCESS/EXIT_CODE_ERRORreturn 0withEXIT_CODE_SUCCESSAll fs commands now use POSIX-compliant exit code constants. Helper functions returning item IDs (not exit codes) are correct as-is. All fs command parsers already use proper POSIX option syntax.