feat(ls): add visual divider between folders and items in workspace listing#19
Draft
feat(ls): add visual divider between folders and items in workspace listing#19
Conversation
fix: semantic pr
chore: Introduce release workflowc
- Add 'Needs Author Feedback' assessment category to all 3 prompts - Rename 'Missing Details' to 'Needs Author Feedback' in bug-triage - Add new category to question-triage and feature-triage - Remove redundant response text fallback and needsHumanReview override - Update workflow label detection to match new category name Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Merge Needs Maintainer Input and Needs Team Review into single Needs Team Review category in question-triage prompt - Remove duplicate needs author feedback label from post-processing (action's ai:* label is sufficient) - Remove ai:* label cleanup (keep action's assessment labels) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract CLI commands, flags, item types, auth methods, and error codes from actual source files. Inject into system prompt (not issue body) so AI backs up answers with real codebase data. Comments and issue body stay clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All AI triage comments now end with a footer instructing users to tag @microsoft/fabric-cli-dev if the issue needs team attention but wasn't escalated by the AI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Approach A (Action): github/ai-assessment-comment-labeler with codebase context injection - Approach B (Code Agent): Custom scripts/ai_triage.py that greps source code and injects into prompt - Both trigger on 'needs triage' label and post tagged comments (🅰️ /🅱️ ) - Both include collapsible label decision tables in comments - Labels suppressed on both for fair testing - Added CLI doc page URLs to all 3 prompt files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- A: Use yaml.safe_load/dump to avoid YAML alias errors from markdown **bold** - A: Remove bold markdown from injected context text - B: Reduce code context limits (30K total, 4K/file, 8 files max) - B: Add API error details to stderr for debugging Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Bug: Potential Bug and Needs Team Review → Escalated to team - Question: Tied each category explicitly to its footer - Feature: Tied each category explicitly to its footer - Removed stale Codebase Reference instruction from feature prompt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove numbered dimension checklists from all 3 prompts - Instruct model to skip adequate aspects, highlight only missing/wrong/notable - Reduce target length from 3-5 to 2-4 paragraphs - Trim verbose preamble in ai_triage.py code context header Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Valuable Enhancement → 📋 Backlog candidate (no escalation) - Help Wanted → 🤝 Community contribution welcome - Out of Scope → ✅ No action needed - Add 'needs discussion' to needsHumanReview in both workflows Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add tailored PEP/RFC/convention references to each prompt: - Bug: packaging, CLI conventions, HTTP/REST, auth, file I/O, runtime - Question: packaging, CLI conventions, HTTP/REST, auth, data formats - Feature: CLI conventions, packaging, HTTP/REST, backward compat, auth Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mpts - Remove Approach B (agent workflow + ai_triage.py), archived on branch - Move codebase reference from pipeline build step into prompt files - Prompts now self-contained: commands, flags, item types, auth, hidden entities - Remove /tmp/prompts indirection, use .github/prompts directly - Clean up A/B testing artifacts (tagged comments, approach labels) - Restore phase control flags (SUPPRESS_LABELS + SUPPRESS_COMMENTS) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…inks Reference https://microsoft.github.io/fabric-cli/essentials/resource_types/ instead of static lists, keeping prompts always up to date. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…s_item Wraps sorted_elements_dict[0].keys() with list() to satisfy the list[str] type expected by format_and_print_output(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…opilot/add-divider-to-ls-output
…opilot/add-divider-to-ls-output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of new changes
When listing workspace contents with
folder_listing_enabled=trueandoutput_format=text, folders and items were displayed in a flat mixed list with no visual separation, reducing readability.This change adds a visual divider (
------------------------------) between folders and items to improve readability when listing workspace contents.Summary: Adds a visual divider between folders and items in
fab lsworkspace listing output. The divider only appears whenfolder_listing_enabled=true,output_format=text, and--longflag is NOT provided. The divider is inserted as a data entry in the sorted results, requiring no changes to rendering logic or core output classes.Context: The original issue requested better visual distinction between folders and items in workspace listings, similar to the behavior when using
-aflag for virtual workspace items. This improves readability and helps users quickly identify folders vs. items in large workspaces.Dependencies: None - uses existing infrastructure and utilities.
Implementation Details
Divider as a data entry:
_DIVIDER = "------------------------------"defined infab_fs_ls_item.py_sort_ws_elements_with_seperation_by_type_order()groups elements by type (Folder, Item), sorts each group using existingsort_ws_elements(), and inserts divider between non-empty groupsfolder_listing_enabled=true(config setting)output_format="text"(not JSON)--longflag NOT providedCode organization:
fab_fs_ls_item.pysort_ws_elements()fromfab_cmd_fs_utils.pyfor consistencyfab_ui.py,fab_output.py, orfab_cmd_ls_utils.pyBehavior Examples
When
folder_listing_enabled=true,output_format=text, and WITHOUT--longflag:When using
--longflag or JSON output:Testing
test_ls_workspace_with_folders_and_items_divider()added to verify divider functionality (marked as skip, requires VCR cassette recording in live environment)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.