apply patch add-xray-response maintained by other RICs#213
Open
bmoffatt wants to merge 3 commits intoawslabs:masterfrom
Open
apply patch add-xray-response maintained by other RICs#213bmoffatt wants to merge 3 commits intoawslabs:masterfrom
bmoffatt wants to merge 3 commits intoawslabs:masterfrom
Conversation
…04 -c "apt-get update && apt-get -y install clang-format && clang-format -i src/runtime.cpp include/aws/lambda-runtime/runtime.h"
marcomagdy
suggested changes
Feb 6, 2026
include/aws/lambda-runtime/runtime.h
Outdated
| std::string const& payload, | ||
| std::string const& content_type, | ||
| bool success, | ||
| std::string const& xray_response = "") |
Contributor
There was a problem hiding this comment.
Please add an overload rather than a default argument.
include/aws/lambda-runtime/runtime.h
Outdated
| static invocation_response failure( | ||
| std::string const& error_message, | ||
| std::string const& error_type, | ||
| std::string const& xray_response = ""); |
Contributor
There was a problem hiding this comment.
Add an overload instead of a default argument, please!
Collaborator
Author
There was a problem hiding this comment.
Hehe Claude picked this approach. Will change it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #209
Description of changes:
I was doing something silly with the Python RIC, and that involved updating it's aws-lambda-cpp version to 0.2.10 (from 0.2.6), and fixing a couple of the patch files that didn't apply. Since I fixed those patches, it seemed fair to apply them upstream too.
This change is effectively the application of https://github.com/aws/aws-lambda-python-runtime-interface-client/blob/main/deps/patches/aws-lambda-cpp-add-xray-response.patch, but changed to make the new constructor parameter optional, and not setting the header if a value wasn't given.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.