Skip to content

Complete conditional check simplification in cloud_engineer_agent.py #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awsdataarchitect merged 4 commits into from
Dec 16, 2025
Merged

Complete conditional check simplification in cloud_engineer_agent.py #7

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40a75cf
Refactor cloud_engineer_agent.py to simplify redundant conditional ch…
kiro-agent Dec 16, 2025
23b178a
Merge remote-tracking branch 'origin/main' into cloudeng-strands-agen…
kiro-agent Dec 16, 2025
d882e00
[skip ci] Restore defensive null checks for MCP clients
amazon-q-developer[bot] Dec 16, 2025
8db684e
Add explicit null checks (is not None) for MCP clients
kiro-agent Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cloud_engineer_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@
aws_diagram_mcp_client = None

# Get tools from MCP clients (if initialized)
docs_tools = aws_docs_mcp_client.list_tools_sync() if mcp_initialized and aws_docs_mcp_client else []
diagram_tools = aws_diagram_mcp_client.list_tools_sync() if mcp_initialized and aws_diagram_mcp_client else []
docs_tools = aws_docs_mcp_client.list_tools_sync() if mcp_initialized and aws_docs_mcp_client is not None else []
diagram_tools = aws_diagram_mcp_client.list_tools_sync() if mcp_initialized and aws_diagram_mcp_client is not None else []

# Create a BedrockModel with system inference profile
bedrock_model = BedrockModel(
Expand Down Expand Up @@ -155,14 +155,14 @@

# Register cleanup handler for MCP clients
def cleanup():
if mcp_initialized:
if mcp_initialized and aws_docs_mcp_client is not None:
try:
aws_docs_mcp_client.stop()
print("AWS Documentation MCP client stopped")
except Exception as e:
print(f"Error stopping AWS Documentation MCP client: {e}")

if mcp_initialized:
if mcp_initialized and aws_diagram_mcp_client is not None:
try:
aws_diagram_mcp_client.stop()
print("AWS Diagram MCP client stopped")
Expand Down