Skip to content

fix(daily-scan): point Trivy at published artifact dependencies#487

Merged
thpierce merged 1 commit intomasterfrom
trivy-scan-published-artifacts
Mar 20, 2026
Merged

fix(daily-scan): point Trivy at published artifact dependencies#487
thpierce merged 1 commit intomasterfrom
trivy-scan-published-artifacts

Conversation

@thpierce
Copy link
Contributor

@thpierce thpierce commented Mar 20, 2026

What

Point Trivy at the published artifact dependency tree (scan-target/) instead of scanning the full repo source at HEAD.

Why

Trivy was scanning scan-ref: '.', which:

  • Picked up sample-apps/flask/requirements.txt — a sample app with urllib3 CVEs that are NOT in the published SDK
  • Scanned source at HEAD, not the released version — a vuln fixed on main but present in the latest release gives a false negative

How

Changed scan-ref from '.' to 'scan-target/', which already contains requirements.txt from pip install aws-xray-sdk && pip freeze. Only runtime deps (wrapt, botocore) — no test or sample app deps.

Local validation

  • Trivy: Parses requirements.txt, 0 vulns (clean — matches expected result since sample app urllib3 CVEs are correctly excluded)

@thpierce thpierce requested a review from a team as a code owner March 20, 2026 16:06
@thpierce thpierce merged commit 3e04555 into master Mar 20, 2026
10 of 15 checks passed
@thpierce thpierce deleted the trivy-scan-published-artifacts branch March 20, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant