fix(daily-scan): scan published artifacts instead of repo source#486
Merged
fix(daily-scan): scan published artifacts instead of repo source#486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DependencyCheck (DC) scans
-s "."which includes DC's own bundled jars in./dependency-check/lib/, producing false positive CVEs (commons-beanutils, h2, logback, gson, httpclient5, etc.).Additionally, scanning source code means if a vulnerability exists in the published artifact but has already been fixed on
main, the scan gives a false negative — customers are still exposed.Fix
Instead of scanning the repo source tree, download/install the published artifact from its package registry into a dedicated
scan-target/directory, then scan only that.This pattern is already proven by ADOT Java and ADOT Python repos.
Changes
scan-target/-s "."to-s "scan-target/"--failOnCVSS 0,--enableExperimental,--nvdApiKey, etc.) are unchangedTesting
Tested locally with DC v12.1.0 against NVD database. Verified: