Open
Conversation
1 task
sbaluja
reviewed
Feb 3, 2026
Sign-off: Rajan Y.(rajanyadav0307@gmail.com)
477c68d to
53aeaa9
Compare
Contributor
Author
|
@sbaluja , Thanks |
Contributor
Author
|
@sbaluja , Please let me know if we are expecting more for the PR. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3613
Description of changes:
This PR adds an opt-out CMake option to prevent the AWS SDK for C++ from exporting
the C++ language standard via pkg-config
Cflags.Currently, the generated
.pcfiles include compiler policy flags (e.g.-std=c++<N>,-fno-exceptions) derived fromAWS_COMPILER_FLAGS. Downstreamprojects that consume the SDK using pkg-config (for example, Meson or custom
build systems) blindly apply these flags, which can override the consumer’s
chosen C++ standard and cause build failures.
To address this without breaking existing users, this PR introduces a new option:
When enabled, the generated pkg-config
Cflagswill no longer include:-std=c++<N>(primary issue reported)-fno-exceptions(also identified as leaking semantics into downstream builds)The default behavior remains unchanged to preserve backward compatibility.
CMake-based consumers are unaffected, as these flags remain
PRIVATEto SDKtargets.
Check all that applies:
Did a review by yourself.
Added proper tests to cover this PR.
Two Docker-based tests were used:
- One Dockerfile builds the upstream SDK and a minimal downstream project
to reliably reproduce the reported failure. Docker_Issue_Repro.zip
- A second Dockerfile builds the SDK with this patch enabled and verifies
that the downstream project builds successfully.Docker-Fix-Verify.zip
Checked if this PR is a breaking (APIs have been changed) change.
Checked if this PR will not introduce cross-platform inconsistent behavior.
Checked if this PR would require a ReadMe/Wiki update.
Check which platforms you have built SDK on to verify the correctness of this PR.
Screenshots:
Issue Reproduced:

Fix-Verify:

By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.
Sign-off: Rajan Y.(rajanyadav0307@gmail.com)