chore(CI): migrate CB CI jobs to GHA#424
Conversation
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
There was a problem hiding this comment.
It's cool that this is now totally native and doesn't shell out to CodeBuild at all.
Do you want to clean up the CodeBuild .yml in this PR or a different one?
I'll clean up in a different pr |
| - name: Install python version specific dependencies | ||
| if: matrix.python-version == '3.12' | ||
| run: | | ||
| pip install -r dev_requirements/ci-requirements.txt |
There was a problem hiding this comment.
I don't fully understand this one -- why just 3.12?
Ditto in the examples file
There was a problem hiding this comment.
for some reason it installs these in the cb job, since python 3.12 requires setuptools and the other versions dont
There was a problem hiding this comment.
Oh! Thanks, I remember this now.
Could you make a comment just above this saying something like
# Python no longer bundles setuptools starting in 3.12
just so we know we'll have to bump this once we add 3.13 support.
Ideally we'd write
matrix.python-version >= '3.12'
but I don't think that works
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.