Prevent attr_encrypted from making queries on load#468
Merged
joshbranham merged 1 commit intoattr-encrypted:masterfrom May 22, 2025
Merged
Prevent attr_encrypted from making queries on load#468joshbranham merged 1 commit intoattr-encrypted:masterfrom
joshbranham merged 1 commit intoattr-encrypted:masterfrom
Conversation
`#attribute_instance_methods_as_symbols` can trigger a query when the schema cache is not loaded. We only need the results of this method if `attribute_instance_methods_as_symbols_available?` is true so we move this inside the check. Signed-off-by: Bojan Marjanovic <marjanovic93@gmail.com>
Contributor
Author
|
Hey @joshbranham 👋 could you please review/merge this tiny fix? 🙇♂️ |
joshbranham
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#attribute_instance_methods_as_symbolscan trigger a query when the schema cache is not loaded.We only need the results of this method if
attribute_instance_methods_as_symbols_available?is true so we move this inside the check.