Suggestion for flash storage auto config#43
Draft
nilu96 wants to merge 2 commits into
Draft
Conversation
I imagine that this will lead to confusion, if the configured settings made in platformio.ini is not respected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi attermann,
thanks for you recent updated to microReticulum and Firmware! I just had a test run on my Heltec T114 and had some issues with the automatic flash detection for nrf-based boards. If I got it right, you want a transition from the user having to configure the flash system himself to the system configuring itself, based on the used platform. I think that's a great approach. What's a bit confusing now is, that the USTORE_XYZ build flags are still needed in platformio.ini to build the firmware successfully. Please have a look at my suggested code changes to streamline the new "auto-config" system.
If you would like to incorporate these suggestions, you would also need to remove all USTORE_USE_XYZ flags from microStore and microReticulum as well. As far as I saw it, this would be no big deal. These flags are used in Adapters/Filestore.h files in microStore.
My suggested code changes fix the following issues:
It would be great if you could habe a look at my suggestions. Thanks and keep up the amazing and important work!
PS: If you need any testing for T114, I would enjoy helping you with that.