Declare directly imported frontend dependencies#591
Merged
mehmetozguldev merged 1 commit intoathasdev:masterfrom Apr 9, 2026
Merged
Declare directly imported frontend dependencies#591mehmetozguldev merged 1 commit intoathasdev:masterfrom
mehmetozguldev merged 1 commit intoathasdev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Current master builds successfully, but several packages are imported directly without being declared directly in
package.json:nanoidvscode-languageserver-typespdfjs-disttailwindcssThose imports currently work because transitive dependencies are hoisted into the top-level
node_modules. Declaring them explicitly makes the dependency graph less fragile and better reflects the actual source-level imports.Validation
bun installbun run typecheckvite build