Skip to content

Declare directly imported frontend dependencies#591

Merged
mehmetozguldev merged 1 commit intoathasdev:masterfrom
Lyapsus:pr/declare-direct-frontend-deps
Apr 9, 2026
Merged

Declare directly imported frontend dependencies#591
mehmetozguldev merged 1 commit intoathasdev:masterfrom
Lyapsus:pr/declare-direct-frontend-deps

Conversation

@Lyapsus
Copy link
Copy Markdown
Contributor

@Lyapsus Lyapsus commented Apr 9, 2026

Summary

  • add direct dependency declarations for packages Athas imports from app code and styles
  • keep the change minimal by matching versions already resolved transitively on current master
  • avoid relying on Bun hoisting transitive dependencies into the app's top-level module tree

Why

Current master builds successfully, but several packages are imported directly without being declared directly in package.json:

  • nanoid
  • vscode-languageserver-types
  • pdfjs-dist
  • tailwindcss

Those imports currently work because transitive dependencies are hoisted into the top-level node_modules. Declaring them explicitly makes the dependency graph less fragile and better reflects the actual source-level imports.

Validation

  • bun install
  • bun run typecheck
  • vite build

Copy link
Copy Markdown
Member

@mehmetozguldev mehmetozguldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@mehmetozguldev mehmetozguldev added the dependencies Pull requests that update a dependency file label Apr 9, 2026
@mehmetozguldev mehmetozguldev merged commit 8b00044 into athasdev:master Apr 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants