feat(OUT-3539): extract findOrMapInvoiceFromQBO helper for invoice sync resilience#216
Draft
SandipBajracharya wants to merge 1 commit intomasterfrom
Draft
feat(OUT-3539): extract findOrMapInvoiceFromQBO helper for invoice sync resilience#216SandipBajracharya wants to merge 1 commit intomasterfrom
SandipBajracharya wants to merge 1 commit intomasterfrom
Conversation
…nc resilience When an invoice is manually created in QBO, subsequent webhook events (paid, void, delete) silently failed because no qb_invoice_sync mapping existed. The new findOrMapInvoiceFromQBO helper queries QBO by invoice number, resolves/creates the customer mapping, and inserts the qb_invoice_sync row so downstream handlers can proceed normally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findOrMapInvoiceFromQBO()helper that queries QBO by invoice number, resolves/creates the customer mapping, and inserts aqb_invoice_syncrow when foundcreated,paid,voided,deleted) as a fallback when no local mapping existscheckIfInvoiceExistsInQBO()to delegate to the new helper, so existing callers (syncMissedInvoices,backfillTimedOutInvoices) automatically gain mapping creationProblem
When an invoice is manually created in QBO, our app tries to create the same invoice and fails. Subsequent
invoice.paid,invoice.void, andinvoice.deleteevents also silently skip because noqb_invoice_syncmapping row exists in our database.Test plan
createdwebhook maps it and skips creationpaid/voided/deletedwebhooks with unmapped invoice → maps from QBO and proceedsfindOrMapInvoiceFromQBOtwice for the same invoice does not create duplicates🤖 Generated with Claude Code