Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a84622d108
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
thesayyn
force-pushed
the
cancel_build
branch
3 times, most recently
from
d49ac8a to
f832370
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8323703cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ede54c4d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be1d678ae9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: thesayyn <thesayyn@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f5f0359c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if still_running { | ||
| // Get the real bazel client PID from the server. | ||
| // If we can't get it, fall back to signalling the wrapper. | ||
| let target_pid = super::info::client_pid(None).unwrap_or(wrapper_pid); |
There was a problem hiding this comment.
build.cancel() looks up both the client PID and server PID with client_pid(None)/server_info(), which always target the default Bazel server, even though ctx.bazel.build() can run with custom startup_flags such as --output_base. In that case, cancel can signal a different in-flight invocation and Cancellation.force() can kill the wrong server while the intended build continues running. The cancellation path should preserve and reuse the build's output-base context (or signal only the spawned child PID).
Useful? React with 👍 / 👎.
| } | ||
| // Server-wide: poll until the server is no longer busy. | ||
| while info::is_server_busy(cancellation.output_base.as_deref()) { | ||
| std::thread::sleep(std::time::Duration::from_millis(poll_ms as u64)); |
There was a problem hiding this comment.
Cancellation.wait() converts poll_ms with poll_ms as u64 before calling Duration::from_millis, so a negative value from Starlark (for example wait(poll_ms = -1)) underflows into a massive sleep interval and effectively hangs the wait loop. Validate or clamp poll_ms to non-negative values before constructing the duration.
Useful? React with 👍 / 👎.
1 participant
Changes are visible to end-users:yes
Implement
ctx.bazel.cancel_invocation()for cancelling previously detached invocation andctx.build().cancel()for in AXL builds.Test plan