fix: include command name and args in process spawn error messages#965
Merged
thesayyn merged 2 commits intoaspect-build:mainfrom Mar 15, 2026
Merged
Conversation
Previously, spawn/status failures only showed the bare OS error (e.g. "No such file or directory (os error 2)") with no indication of what command was being invoked. Now errors include the full command via Debug output from std::process::Command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 990454f64c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uses get_program()/get_args() rather than Debug formatting on std::process::Command to avoid leaking environment variables.
thesayyn
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, spawn/status failures only showed the bare OS error (e.g. "No such file or directory (os error 2)") with no indication of what command was being invoked. Now errors include the full command and args via Debug output from std::process::Command.
This was relatively straight-forward to address with axl command spawn/status calls, but bazel spawns are less modular. There's a whole class of error there that isn't currently surfaced to users at all and might benefit from some light abstraction around sourcing bazel and the workspace. For instance, I had a developer that used a shell alias for bazel which isn't provided to the subprocess. OS error 2 was the only indication of the failure. aspect-cli also doesn't work when run via multitool because finding the bazel server gets confused by being inside the runfiles tree. This is out of scope for this fix, but figured I'd mention it in case these changes would considered beneficial.
Affected code paths:
ctx.std.process.command().spawn()/.status()(axl stdlib)ctx.bazel.build()(bazel build/test spawn)Build::server_info()(bazel info spawn)Query::query()(bazel query spawn)Changes are visible to end-users: yes
Test plan
spawn_error_includes_command_and_argsstatus_error_includes_command_and_args