Draft
Conversation
83063aa to
affe055
Compare
affe055 to
1fdcdbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the release fetcher fails if it finds a release without any assets. This is possible is you happen to check the latest release mid-release when it doesn't have any assets yet. This improves the code so that it falls back to the latest release that has an asset to download when searching.
Before
The GitHub source handler had a single code path for both pinned and unpinned versions:
v{version}— for unpinned,versionwas always the launcher's own compiled-in versionGET /repos/{org}/{repo}/releases/tags/{tag}assetsarrayapi.github.com/.../assets/{id})Problems:
Releasestruct required theassetsfield, but GitHub sometimes omits it →missing field 'assets'deserialization errorversion_pinnedboolean was threaded throughToolSpec/AspectCliConfigbut both paths used the same download logicAfter
The GitHub source handler is now split into two clean steps — resolve, then download:
Step 1 — Resolve the tag:
version = Some("2026.11.6")fromversion.axl): compute the tag directly (e.g.v2026.11.6). No API call.version = None— noversion.axl, orversion()with no positional arg): queryGET /repos/{org}/{repo}/releases?per_page=10, scan the most recent releases, and pick the first one whoseassetscontain the matching artifact.Step 2 — Download using the resolved tag:
Both paths now have a concrete tag and use the same direct download URL:
https://github.com/{org}/{repo}/releases/download/{resolved_tag}/{artifact}What this fixes:
assetsnow has#[serde(default)], so releases with missing or empty assets are skipped instead of causing a deserialization errorversion_pinnedboolean is removed;version: Option<String>onToolSpecnaturally encodes the distinction (Some= pinned,None= resolve from API)