feat: support for remote.execution and remote.logging apis#958
feat: support for remote.execution and remote.logging apis#958
Conversation
thesayyn
changed the title
thesayyn
force-pushed
the
proto-client-changes
branch
from
27db6a7 to
03e6a0d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27db6a746d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Err(e) => { | ||
| *stream_opt = None; | ||
| panic!("stream error: {}", e); |
There was a problem hiding this comment.
In the streaming branch generated by try_service, the iterator path used by for ... in stream panics when stream.message() returns an error. Any transient gRPC failure (for example cancellation or connection loss) during remote execution/logging iteration will terminate the whole process instead of producing a recoverable Starlark error or clean stream end, which is a production-facing reliability regression.
Useful? React with 👍 / 👎.
| elif path.startswith("%workspace%"): | ||
| path = _resolve_import_path(path, workspace_dir, "") | ||
|
|
||
| result = parse_file(path, workspace_dir = workspace_dir, std = std) |
There was a problem hiding this comment.
bazelrc() calls parse_file() and then immediately returns flags without checking result["errors"]. Because parse_file() encodes missing files/import failures/circular imports in that error list, callers currently get empty or partial flags silently instead of a failure, which can quietly misconfigure build/remote settings and is hard to debug.
Useful? React with 👍 / 👎.
thesayyn
force-pushed
the
proto-client-changes
branch
from
03e6a0d to
053bda8
Compare
1 participant
Changes are visible to end-users: yes
Support for experimental
remote.executionandremote.loggingapis.Test plan