Skip to content

fix(Aggregate Uniq Count): #698

Draft
simpers wants to merge 1 commit intoash-project:mainfrom
simpers:aggregate-unique-count-issue
Draft

fix(Aggregate Uniq Count): #698
simpers wants to merge 1 commit intoash-project:mainfrom
simpers:aggregate-unique-count-issue

Conversation

@simpers
Copy link
Contributor

@simpers simpers commented Feb 20, 2026

Added a test to demonstrate the aggregate issue

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@simpers simpers force-pushed the aggregate-unique-count-issue branch from 526ca6c to b795cf1 Compare February 20, 2026 10:49
@simpers simpers force-pushed the aggregate-unique-count-issue branch from b795cf1 to 396b80a Compare February 20, 2026 11:16
@simpers
Copy link
Contributor Author

simpers commented Feb 20, 2026

Ignore this for now, as I had forgotten that the SQL stuff is (probably) in AshSql. The unit test shows the issue though, but the fix is probably not in this repo.

Whether it is useful to have these tests here anyway, I'm not sure, but until I redo this in the AshSql repo I'll just keep this here for my own memory 🤓

@zachdaniel
Copy link
Contributor

@simpers we actually don't really have tests in ash_sql so generally we commit failing tests here and then fix it in ash_sql. 😄

@zachdaniel
Copy link
Contributor

If you're ready to merge this then lets mark it ready and I'll merge 🙇

@simpers
Copy link
Contributor Author

simpers commented Feb 21, 2026

@simpers we actually don't really have tests in ash_sql so generally we commit failing tests here and then fix it in ash_sql. 😄

Haha I noticed that after posting 😅 I will try to wrap it up tonight or tomorrow, bit swamped at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants