Fix: payments not updating #2755

ItzNotABug · 2026-01-02T13:59:39Z

What does this PR do?

Was reusing the organization loaded from root which had outdated data and therefore none of the invalidates were working.

Test Plan

Manual.

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

New Features
- Enhanced payment method management with explicit primary and backup payment method tracking across billing pages.
- Improved card replacement with country/state validation for payment method updates.
Bug Fixes
- Fixed method naming in backup payment method removal flow to ensure correct operation.
Refactor
- Streamlined internal component prop handling and state management for payment operations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

appwrite · 2026-01-02T13:59:43Z

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL

Tip

Build commands execute in runtime containers during deployment

coderabbitai · 2026-01-02T13:59:52Z

Warning

Rate limit exceeded

@ItzNotABug has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4eda58b and fdc94a5.

📒 Files selected for processing (1)

src/routes/(console)/organization-[organization]/billing/replaceCard.svelte

Walkthrough

This pull request refactors payment management functionality across multiple components and pages. The changes include migrating component prop declarations from traditional export let statements to Svelte 5's $props() destructuring pattern in three components (editPaymentModal, replaceCard, and related files). Additionally, the payment method state management is reorganized by extracting primary and backup payment method identification logic into the page load layer, then passing these as explicit props to child components. The organization layout's checkPlatformAndRedirect function is updated to return void instead of an Organization object, with direct SDK fetching moved to the load function. API invalidation targets are adjusted from ORGANIZATION to PAYMENT_METHODS in certain flows.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title check	❓ Inconclusive	The title is vague and generic, using only 'Fix: payments not updating' without specifying which payments mechanism is being fixed or how.	Consider a more descriptive title that specifies the root cause (e.g., 'Fix: invalidate payment methods by fetching fresh org data instead of reusing cached') or the specific component area being fixed.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

src/routes/(console)/organization-[organization]/+layout.ts (1)
90-111: Return statements in void function are misleading.

The function signature indicates it returns void (no explicit return type), but the function body contains return null (line 107) and return requestedOrg (line 111). While these returns are harmless since the caller no longer uses the return value, they're misleading and should be cleaned up for clarity.
🔎 Suggested cleanup
     // not found, load!
     if (!requestedOrg) {
         try {
             requestedOrg = (await sdk.forConsole.teams.get({
                 teamId: params.organization
             })) as Organization;
         } catch (e) {
-            return null;
+            return;
         }
     }

-    if (!isCloud) return requestedOrg;
+    if (!isCloud) return;

     if (requestedOrg && requestedOrg.platform !== Platform.Appwrite) {

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11a42cf and 4eda58b.

📒 Files selected for processing (7)

src/routes/(console)/account/payments/editPaymentModal.svelte
src/routes/(console)/organization-[organization]/+layout.ts
src/routes/(console)/organization-[organization]/billing/+page.svelte
src/routes/(console)/organization-[organization]/billing/+page.ts
src/routes/(console)/organization-[organization]/billing/deleteOrgPayment.svelte
src/routes/(console)/organization-[organization]/billing/paymentMethods.svelte
src/routes/(console)/organization-[organization]/billing/replaceCard.svelte

🧰 Additional context used

📓 Path-based instructions (6)

**/*.{ts,tsx,js,jsx,svelte}