Skip to content

TEZ-4711: Normalize ASF license header#488

Open
Aggarwal-Raghav wants to merge 3 commits intoapache:masterfrom
Aggarwal-Raghav:TEZ-4711
Open

TEZ-4711: Normalize ASF license header#488
Aggarwal-Raghav wants to merge 3 commits intoapache:masterfrom
Aggarwal-Raghav:TEZ-4711

Conversation

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Apr 21, 2026

For yml, sh and dockerfile have manually fixed them. becuase of delimiters and comments in files, there is no generic regex for them.
Maybe this can help: https://github.com/geruh/incubator-xtable/blob/7c7b54b3870791578b4689b29cf8794866eefa52/pom.xml#L542-L633 but it will still require manual intervention at first

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 7s #488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/1/console
versions git=2.34.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 6s #488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/2/console
versions git=2.34.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Copy Markdown
Contributor

abstractdog commented May 2, 2026

this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :)
let me replay the last test job with a workaround to apply large patches (#423 (comment))
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/

the precommit test is crucial this time even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us

@tez-yetus
Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/console in case of problems.

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 3m 7s Docker failed to build run-specific yetus/tez:tp-20616}.
Subsystem Report/Notes
GITHUB PR #488
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4/console in case of problems.

@abstractdog
Copy link
Copy Markdown
Contributor

abstractdog commented May 2, 2026

this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :) let me replay the last test job with a workaround to apply large patches (#423 (comment)) https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/

the precommit test is crucial even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us

timeout happened in
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3
rerunning as
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 2m 13s Docker failed to build run-specific yetus/tez:tp-20678}.
Subsystem Report/Notes
GITHUB PR #488
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/5/console in case of problems.

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 2m 12s Docker failed to build run-specific yetus/tez:tp-29023}.
Subsystem Report/Notes
GITHUB PR #488
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/5/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/6/console in case of problems.

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 2m 12s Docker failed to build run-specific yetus/tez:tp-10271}.
Subsystem Report/Notes
GITHUB PR #488
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/6/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 6s #488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/7/console
versions git=2.34.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor Author

Aggarwal-Raghav commented May 2, 2026

Same error I'm getting locally as well when building docker image.
Screenshot 2026-05-03 at 12 00 12 AM

Maybe with latest change in go repo can you please apply the workaround @abstractdog ? I'm not sure where this go is used anyway? I'm thinking of optimizing this dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants