You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :)
let me replay the last test job with a workaround to apply large patches (#423 (comment)) https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/
the precommit test is crucial this time even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us
this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :) let me replay the last test job with a workaround to apply large patches (#423 (comment)) https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/
the precommit test is crucial even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us
Same error I'm getting locally as well when building docker image.
Maybe with latest change in go repo can you please apply the workaround @abstractdog ? I'm not sure where this go is used anyway? I'm thinking of optimizing this dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For yml, sh and dockerfile have manually fixed them. becuase of delimiters and comments in files, there is no generic regex for them.
Maybe this can help: https://github.com/geruh/incubator-xtable/blob/7c7b54b3870791578b4689b29cf8794866eefa52/pom.xml#L542-L633 but it will still require manual intervention at first