[SQL] Update grammar/TableChange to allow CLUSTER BY expressions#55327
Open
itsbilal wants to merge 1 commit intoapache:masterfrom
Open
[SQL] Update grammar/TableChange to allow CLUSTER BY expressions#55327itsbilal wants to merge 1 commit intoapache:masterfrom
itsbilal wants to merge 1 commit intoapache:masterfrom
Conversation
This change updates the parser grammar and the TableChange API to allow representing tables that have CLUSTER BY clauses on expressions (eg. `CLUSTER BY (variant_get(col, ...))` instead of just CLUSTER BY `(col)`. The goal is to make this TableChange backward-compatible with connectors that only support clustering by raw columns, while allowing connectors to opt-into supporting some transforms if they are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change updates the parser grammar and the TableChange API to allow representing tables that have CLUSTER BY clauses on expressions (eg.
CLUSTER BY (variant_get(col, ...))instead of just CLUSTER BY(col).The goal is to make this TableChange backward-compatible with connectors that only support clustering by raw columns, while allowing connectors to opt-into supporting some transforms if they are present.
Why are the changes needed?
To support the use-case of being able to do eg.
ALTER TABLE ... CLUSTER BY (upper(col))Does this PR introduce any user-facing change?
Yes, this is a user-facing change - it adds new functionality but does not change any existing functionality.
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
Used claude code with opus 4.6 to assist in this change, but most of it was manually written.